-
Notifications
You must be signed in to change notification settings - Fork 19
ETW Threat-Intelligence API Event metrics #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -846,17 +896,17 @@ | |||
index: false | |||
description: The total milliseconds spent queueing process events for the process over the last week | |||
|
|||
- name: metrics.system_impact.etw_events.week_ms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add new mappings for these instead of renaming? The reason being is that there will still be old Endpoints that stream data to these fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. Sorry for not providing the background on this. I've been removing vestigial code in endpoint-dev
- and just did the same here automatically.
So Endpoint has never generated etw_events
metrics. This appears to have been added optimistically because of a feature in endgame and never used.
cc: @nfritts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the explanation. This should be fine to merge as long as we're sure there's no backwards compatibility issues with older Endpoints
|
||
- name: metrics.documents_volume.api_events.sources.source | ||
level: custom | ||
type: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have been keyword
.
See #373
Package endpoint - 8.9.0 containing this change is available at https://epr.elastic.co/search?package=endpoint |
Change Summary
Adds new metrics fields for the API Event type and the ETW Threat-Intelligence API Event provider.
Release Target
These events are diagnostic in 8.8 and will be released in a future version.
For mapping changes:
make
after making the schema changes, and committed all changesmetadata
change, I also updated both transform destination schemas to match