Skip to content

Add thread callstacks to process, file, registry, and image/library load events #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2023

Conversation

gabriellandau
Copy link
Contributor

@gabriellandau gabriellandau commented Apr 5, 2023

Change Summary

This PR adds thread callstacks to process, file, registry, and image/library load events. Callstacks for process events are attributed to the parent at process.parent.thread.Ext.call_stack. For the other listed events, they're attributed to the acting process at process.thread.Ext.call_stack.

Callstacks will not be sent to ES in events by default. Rather, they will be sent to Endpoint's behavioral protection engine (aka rules engine). When a rule fires and generates an alert, the alert includes a list of events which triggered the rule. Callstacks will be included in such events.

For users who want all the data all the time, there will be a new advanced policy option to allow users to get callstacks in supported regular events.

Sample values

See included sample docs.

Release Target

8.8.0

Q/A

For mapping changes:

  • I ran make after making the schema changes, and committed all changes

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-10T21:01:27.788+0000

  • Duration: 8 min 55 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@gabriellandau gabriellandau marked this pull request as ready for review April 6, 2023 17:44
@gabriellandau gabriellandau requested a review from a team as a code owner April 6, 2023 17:44
@gabriellandau
Copy link
Contributor Author

assigned from elastic/security-defend-workflows

@dasansol92 and/or @gergoabraham it looks like you were chosen by the GitHub lottery. Can you take a look at this PR?

@kevinlog
Copy link
Contributor

@gabriellandau apologies - David and Gergo have been on PTO. I checked it out and reviewed it.

There are only mapping additions here which are safer changes to make.

The new package installs after correcting the type from this commit: 1a5d4bf

I'm able to stream the new sample process doc with the new value
image

LGTM!

@gabriellandau
Copy link
Contributor Author

Thanks @kevinlog!

@gabriellandau gabriellandau merged commit 4bf9ef1 into main Apr 10, 2023
@gabriellandau gabriellandau deleted the callstacks-to-prod-part-1 branch April 10, 2023 21:23
@elasticmachine
Copy link
Contributor

Package endpoint - 8.8.0 containing this change is available at https://epr.elastic.co/search?package=endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants