Fix minmax normalizer handling of single-doc result sets #128689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @Mikep86, I've created a changelog YAML for you. |
pmpailis
reviewed
Jun 2, 2025
...plugin/rank-rrf/src/main/java/org/elasticsearch/xpack/rank/linear/MinMaxScoreNormalizer.java
Show resolved
Hide resolved
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Jun 2, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Jun 2, 2025
) (cherry picked from commit adda402) # Conflicts: # x-pack/plugin/rank-rrf/src/main/java/org/elasticsearch/xpack/rank/RankRRFFeatures.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Jun 2, 2025
) (cherry picked from commit adda402) # Conflicts: # x-pack/plugin/rank-rrf/src/main/java/org/elasticsearch/xpack/rank/RankRRFFeatures.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 2, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 2, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 2, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 3, 2025
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Jun 3, 2025
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/elasticsearch
that referenced
this pull request
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the
minmaxnormalizer logic that causes it to return the unnormalized score when handling a single-doc result set. This PR fixes the bug and adds a YAML test for the fix.