Skip to content

[ML] Pass timeout to chat completion #128338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 23, 2025
Merged

[ML] Pass timeout to chat completion #128338

merged 5 commits into from
May 23, 2025

Conversation

prwhelan
Copy link
Member

Use non-nullable Timeout as the currently null chat completion timeout

@prwhelan prwhelan added >bug :ml Machine learning Team:ML Meta label for the ML team auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 v9.0.3 v8.18.3 labels May 22, 2025
@prwhelan prwhelan marked this pull request as ready for review May 22, 2025 20:20
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Collaborator

Hi @prwhelan, I've created a changelog YAML for you.

@prwhelan prwhelan mentioned this pull request May 22, 2025
Merged
jonathan-buttner
jonathan-buttner approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix Pat!

@prwhelan prwhelan enabled auto-merge (squash) May 23, 2025 12:20
@prwhelan prwhelan merged commit c96a99a into elastic:main May 23, 2025
19 checks passed
prwhelan added a commit to prwhelan/elasticsearch that referenced this pull request May 23, 2025
@prwhelan
[ML] Pass timeout to chat completion (elastic#128338)
a2ce2e1
@prwhelan prwhelan mentioned this pull request May 23, 2025
Merged
prwhelan added a commit to prwhelan/elasticsearch that referenced this pull request May 23, 2025
@prwhelan
[ML] Pass timeout to chat completion (elastic#128338)
d84558a
@prwhelan prwhelan mentioned this pull request May 23, 2025
Merged
prwhelan added a commit to prwhelan/elasticsearch that referenced this pull request May 23, 2025
@prwhelan
[ML] Pass timeout to chat completion (elastic#128338)
cd52927
@prwhelan prwhelan mentioned this pull request May 23, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.19
✅ 9.0
✅ 8.18

elasticsearchmachine pushed a commit that referenced this pull request May 23, 2025
@prwhelan
[ML] Pass timeout to chat completion (#128338) (#128380)
fd89678
elasticsearchmachine pushed a commit that referenced this pull request May 23, 2025
@prwhelan
[ML] Pass timeout to chat completion (#128338) (#128379)
7ff1f7f
elasticsearchmachine pushed a commit that referenced this pull request May 23, 2025
@prwhelan
[ML] Pass timeout to chat completion (#128338) (#128381)
daf5bf3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged >bug :ml Machine learning Team:ML Meta label for the ML team v8.18.3 v8.19.0 v9.0.3 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prwhelan @elasticsearchmachine @jonathan-buttner