[ML] Prevent retention classes from failing when deleting documents in read-only indices #125408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @valeriy42, I've created a changelog YAML for you. |
…olver for improved index handling
…b.com/valeriy42/elasticsearch into enhancement/1532-unused-stats-remover
…enhancement/1532-unused-stats-remover
davidkyle
reviewed
Apr 9, 2025
| @@ -31,6 +31,7 @@ abstract class AbstractExpiredJobDataRemover implements MlDataRemover { | |||
| this.client = client; | |||
| this.jobIterator = jobIterator; | |||
| this.parentTaskId = parentTaskId; | |||
|
|
|||
…managing writable indices
…enhancement/1532-unused-stats-remover
There was a problem hiding this comment.
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
docs/changelog/125408.yaml:2
- Typo detected: 'UnusuedStatsRemover' should be corrected to 'UnusedStatsRemover'.
summary: Prevent `UnusuedStatsRemover` from failing when deleting documents in read-only indices
…b.com/valeriy42/elasticsearch into enhancement/1532-unused-stats-remover
…mover' into enhancement/1532-unused-stats-remover
davidkyle
reviewed
May 22, 2025
.../ml/src/main/java/org/elasticsearch/xpack/ml/job/retention/ExpiredModelSnapshotsRemover.java
Outdated
Show resolved
Hide resolved
.../ml/src/main/java/org/elasticsearch/xpack/ml/job/retention/ExpiredModelSnapshotsRemover.java
Show resolved
Hide resolved
💔 Backport failed
You can use sqren/backport to manually backport by running |
valeriy42
added a commit
to valeriy42/elasticsearch
that referenced
this pull request
Jun 2, 2025
…n read-only indices (elastic#125408) Classes like UnusedStatsRemover delete orphaned documents without an associated job. When the indices are made read-only it will start failing as read-only means no delete. This PR ensures that the non-writable indices are not included in the delete-by-query requests. (cherry picked from commit c822a57)
valeriy42
added a commit
to valeriy42/elasticsearch
that referenced
this pull request
Jun 2, 2025
…n read-only indices (elastic#125408) Classes like UnusedStatsRemover delete orphaned documents without an associated job. When the indices are made read-only it will start failing as read-only means no delete. This PR ensures that the non-writable indices are not included in the delete-by-query requests. (cherry picked from commit c822a57)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
valeriy42
added a commit
to valeriy42/elasticsearch
that referenced
this pull request
Jun 2, 2025
…n read-only indices (elastic#125408) Classes like UnusedStatsRemover delete orphaned documents without an associated job. When the indices are made read-only it will start failing as read-only means no delete. This PR ensures that the non-writable indices are not included in the delete-by-query requests. (cherry picked from commit c822a57)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 2, 2025
…ments in read-only indices (#125408) (#128748) * [ML] Prevent retention classes from failing when deleting documents in read-only indices (#125408) Classes like UnusedStatsRemover delete orphaned documents without an associated job. When the indices are made read-only it will start failing as read-only means no delete. This PR ensures that the non-writable indices are not included in the delete-by-query requests. (cherry picked from commit c822a57) * [CI] Auto commit changes from spotless * fit build failure --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 2, 2025
…ents in read-only indices (#125408) (#128747) * [ML] Prevent retention classes from failing when deleting documents in read-only indices (#125408) Classes like UnusedStatsRemover delete orphaned documents without an associated job. When the indices are made read-only it will start failing as read-only means no delete. This PR ensures that the non-writable indices are not included in the delete-by-query requests. (cherry picked from commit c822a57) * [CI] Auto commit changes from spotless * fit build failure --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 2, 2025
…ments in read-only indices (#125408) (#128749) * [ML] Prevent retention classes from failing when deleting documents in read-only indices (#125408) Classes like UnusedStatsRemover delete orphaned documents without an associated job. When the indices are made read-only it will start failing as read-only means no delete. This PR ensures that the non-writable indices are not included in the delete-by-query requests. (cherry picked from commit c822a57) * [CI] Auto commit changes from spotless * fit build failure --------- Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes like UnusedStatsRemover delete orphaned documents without an associated job. When the indices are made read-only it will start failing as read-only means no delete.
This PR ensures that the non-writable indices are not included in the delete-by-query requests.