-
Notifications
You must be signed in to change notification settings - Fork 25.4k
Handle long overflow in dates #124048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle long overflow in dates #124048
Conversation
Hi @smalyshev, I've created a changelog YAML for you. |
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
35b41dd
to
3456bbd
Compare
This fix seems to be linked as well with #125321 , can you double check? |
@javanna Unfortunately I can't reproduce the issue as described in #125321 but if somehow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm from a core/infra perspective 👍
💔 Backport failed
You can use sqren/backport to manually backport by running |
* Handle long overflow in dates (cherry picked from commit 07921a7) # Conflicts: # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search/500_date_range.yml # server/src/main/java/org/elasticsearch/index/mapper/DateFieldMapper.java # server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java
* Handle long overflow in dates (cherry picked from commit 07921a7) # Conflicts: # server/src/main/java/org/elasticsearch/index/mapper/DateFieldMapper.java # server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* Handle long overflow in dates (cherry picked from commit 07921a7) # Conflicts: # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search/500_date_range.yml # server/src/main/java/org/elasticsearch/index/mapper/DateFieldMapper.java # server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java
* Handle long overflow in dates (#124048) * Handle long overflow in dates (cherry picked from commit 07921a7) # Conflicts: # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search/500_date_range.yml # server/src/main/java/org/elasticsearch/index/mapper/DateFieldMapper.java # server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java * Add import
* Handle long overflow in dates (#124048) * Handle long overflow in dates (cherry picked from commit 07921a7) # Conflicts: # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search/500_date_range.yml # server/src/main/java/org/elasticsearch/index/mapper/DateFieldMapper.java # server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java * Add import
* Handle long overflow in dates
This makes sure that dates that overflow a long fail with a reasonable message rather than an ArithmeticException. This mostly just hits the field mapper.
Update on #112650
Fixes #112483