[ML] Set Connect Timeout to 5s #123272
Merged
[ML] Set Connect Timeout to 5s #123272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduced connection timeout from infinite to a system configurable setting that defaults to 5s. Increased EIS auth token timeout from 30s to 1m.
|
Hi @prwhelan, I've created a changelog YAML for you. |
|
Pinging @elastic/ml-core (Team:ML) |
timgrein
reviewed
Feb 24, 2025
| @@ -89,6 +91,12 @@ public class HttpClientManager implements Closeable { | |||
| Setting.Property.Dynamic | |||
| ); | |||
|
|
|||
| public static final Setting<TimeValue> CONNECTION_TIMEOUT = Setting.timeSetting( | |||
There was a problem hiding this comment.
Does this need to be added to getSettingsDefinitions?
| @@ -89,6 +91,12 @@ public class HttpClientManager implements Closeable { | |||
| Setting.Property.Dynamic | |||
| ); | |||
|
|
|||
| public static final Setting<TimeValue> CONNECTION_TIMEOUT = Setting.timeSetting( | |||
There was a problem hiding this comment.
How about we move this into HttpSettings. I don't think we need to add a addSettingsUpdateConsumer because we'd have to close the client and recreate it but I think that class was for the settings for the client.
jonathan-buttner
approved these changes
Feb 24, 2025
timgrein
approved these changes
Feb 24, 2025
This was referenced Feb 24, 2025
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Feb 24, 2025
Reduced connection timeout from infinite to a system configurable setting that defaults to 5s. Increased EIS auth token timeout from 30s to 1m.
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Feb 24, 2025
Reduced connection timeout from infinite to a system configurable setting that defaults to 5s. Increased EIS auth token timeout from 30s to 1m.
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Feb 24, 2025
Reduced connection timeout from infinite to a system configurable setting that defaults to 5s. Increased EIS auth token timeout from 30s to 1m.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced connect timeout from system default to a system configurable setting that defaults to 5s. This value controls the time waiting for a connection to be established.
Increased EIS auth token timeout from 30s to 1m.