Skip to content

Add remove_index_block arg to _create_from api #120548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

parkertimmins
Copy link
Contributor

Add a new boolean parameter remove_index_blocks from the _create_from API.
If this parameter is set to true, all index block will be filtered out when creating the destination index.
This will override any index block set in either the source index settings or the settings_override parameter.

Using this argument will be equivalent to passing

"settings_override": {
"index.blocks.write": null,
"index.blocks.read": null,
"index.blocks.read_only": null,
"index.blocks.read_only_allow_delete": null,
"index.blocks.metadata": null
}

This parameter will default to false.

@parkertimmins parkertimmins added >enhancement :Data Management/Indices APIs APIs to create and manage indices and templates auto-backport Automatically create backport pull requests when merged v9.0.0 v8.18.0 labels Jan 21, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jan 21, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @parkertimmins, I've created a changelog YAML for you.

@masseyke masseyke self-requested a review January 21, 2025 20:26
Copy link
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if this would be useful to the upgrade assistant. Just a reminder, we'll need to update the specification here: https://github.com/elastic/elasticsearch-specification/blob/main/specification/migrate/create_from/MigrateCreateFromRequest.ts#L45

@parkertimmins parkertimmins merged commit f404da0 into elastic:main Jan 21, 2025
16 checks passed
@parkertimmins parkertimmins deleted the create-index-from-source-write-blocks branch January 21, 2025 21:50
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

parkertimmins added a commit to parkertimmins/elasticsearch that referenced this pull request Jan 21, 2025
Add a new boolean parameter remove_index_blocks from the _create_from API.
If this parameter is set to true, all index block will be filtered out when creating the destination index.
elasticsearchmachine pushed a commit that referenced this pull request Jan 21, 2025
Add a new boolean parameter remove_index_blocks from the _create_from API.
If this parameter is set to true, all index block will be filtered out when creating the destination index.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Data Management/Indices APIs APIs to create and manage indices and templates >enhancement Team:Data Management Meta label for data/management team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants