Skip to content

Merge field mappers when updating mappings with [subobjects:false] #120370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 21, 2025

Conversation

kkrik-es
Copy link
Contributor

Fixes #120216

@kkrik-es kkrik-es added >bug auto-backport Automatically create backport pull requests when merged Team:StorageEngine :StorageEngine/Mapping The storage related side of mappings v8.18.0 labels Jan 17, 2025
@kkrik-es kkrik-es self-assigned this Jan 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @kkrik-es, I've created a changelog YAML for you.

@kkrik-es kkrik-es marked this pull request as ready for review January 21, 2025 08:52
@kkrik-es kkrik-es requested a review from martijnvg January 21, 2025 08:52
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkrik-es kkrik-es merged commit 0a5d2e7 into elastic:main Jan 21, 2025
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 120370

@kkrik-es
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

kkrik-es added a commit to kkrik-es/elasticsearch that referenced this pull request Jan 21, 2025
…lastic#120370)

* Merge field mappers when updating mappings with [subobjects:false]

* Update docs/changelog/120370.yaml

* fix and add tests

* node feature guarding

(cherry picked from commit 0a5d2e7)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java
kkrik-es added a commit that referenced this pull request Jan 21, 2025
…120370) (#120520)

* Merge field mappers when updating mappings with [subobjects:false]

* Update docs/changelog/120370.yaml

* fix and add tests

* node feature guarding

(cherry picked from commit 0a5d2e7)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java
@kkrik-es kkrik-es deleted the fix/120216 branch January 29, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged backport pending >bug :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapping type changes not properly validated with subobjects: false
3 participants