Make requests_per_second configurable to throttle reindexing #120207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @lukewhiting, I've created a changelog YAML for you. |
.../main/java/org/elasticsearch/xpack/migrate/action/ReindexDataStreamIndexTransportAction.java
Outdated
Show resolved
Hide resolved
Also allow -1 as infinite
…-make-rps-configurable
masseyke
reviewed
Jan 16, 2025
.../main/java/org/elasticsearch/xpack/migrate/action/ReindexDataStreamIndexTransportAction.java
Outdated
Show resolved
Hide resolved
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 16, 2025
#120300) * Make requests_per_second configurable to throttle reindexing * Update docs/changelog/120207.yaml * Add restrictions to prevent zero or negative rate limit Also allow -1 as infinite * PR Changes - Switch to cluster settings for rate limit retrieval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on introducing a new setting for reindexing data streams and adding corresponding tests. The changes include adding a new setting for the maximum number of reindex requests per second, modifying the reindex method to incorporate this setting, and creating a new test class to verify the functionality.
Key changes include:
New Setting Addition:
REINDEX_MAX_REQUESTS_PER_SECOND_SETTINGto control the maximum number of reindex requests per second inReindexDataStreamIndexTransportAction.Code Modifications:
reindexmethod inReindexDataStreamIndexTransportActionto use the newREINDEX_MAX_REQUESTS_PER_SECOND_SETTINGfor reindex requests.MigratePluginand added it to the list of plugin settings. [1] [2]Test Enhancements:
generateDestIndexNamefromReindexDatastreamIndexTransportActionITand added them to a new test classReindexDataStreamIndexTransportActionTests. [1] [2] as they are unit tests not ITs.ReindexDataStreamIndexTransportActionTeststo verify that the reindex method's reindex requests includes the rate limit setting.