Skip to content

Run TransportClusterGetSettingsAction on local node #119831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

nielsbauman
Copy link
Contributor

@nielsbauman nielsbauman commented Jan 9, 2025

This action solely needs the cluster state, it can run on any node. Additionally, it needs to be cancellable to avoid doing unnecessary work after a client failure or timeout. The ?local parameter becomes a no-op and is marked as deprecated.

Relates #101805
Relates #107984

This action solely needs the cluster state, it can run on any node.
Additionally, it needs to be cancellable to avoid doing unnecessary
work after a client failure or timeout.
@nielsbauman nielsbauman added >enhancement :Core/Infra/Settings Settings infrastructure and APIs Team:Core/Infra Meta label for core/infra team v9.0.0 labels Jan 9, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Hi @nielsbauman, I've created a changelog YAML for you.

@nielsbauman
Copy link
Contributor Author

I initially mistakenly thought Data Management owned this API but I just realized we don't. Since I had the changes already, I just opened a PR anyway.

Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, and I follow your reasoning why this can run on any node as everything is read from state.metadata. There might have been some undocumented/unrelated reasons why this should have run on a master, but I cannot think of any.

@nielsbauman nielsbauman enabled auto-merge (squash) January 14, 2025 02:44
@nielsbauman nielsbauman merged commit 4ccd377 into elastic:main Jan 14, 2025
16 checks passed
@nielsbauman nielsbauman deleted the local-cluster-settings branch January 14, 2025 03:46
martijnvg pushed a commit to martijnvg/elasticsearch that referenced this pull request Jan 14, 2025
This action solely needs the cluster state, it can run on any node.
Additionally, it needs to be cancellable to avoid doing unnecessary
work after a client failure or timeout. The `?local` parameter
becomes a no-op and is marked as deprecated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Settings Settings infrastructure and APIs >enhancement Team:Core/Infra Meta label for core/infra team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants