Skip to content

Add ESQL telemetry collection #119474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Jan 2, 2025
Merged

Add ESQL telemetry collection #119474

merged 35 commits into from
Jan 2, 2025

Conversation

smalyshev
Copy link
Contributor

@smalyshev smalyshev commented Jan 2, 2025 •
edited
Loading

Adds _esql section to ccs metrics at _cluster/stats. Only available when any ES|QL queries have been performed.

Taking over from #117282, see more comments there.

smalyshev and others added 28 commits November 22, 2024 14:15
@smalyshev
Add ESQL telemetry collection
59cfd29
@smalyshev
Move object name out of CCSTelemetrySnapshot
095f342
@smalyshev
Add esql telemetry to stats output
7233eda
@smalyshev
Update docs/changelog/117282.yaml
4b2882f
@smalyshev
Spotless
bbf6dca
@smalyshev
Add wrappings to capture more errors
f193a4d
@smalyshev
Add test (more to come)
5137537
@smalyshev
Merge branch 'main' into esql-telemetry
20f91c5
@smalyshev
Add comment
5a84912
@smalyshev
Fix test
9d42179
@smalyshev
Merge branch 'main' into esql-telemetry
fd812df
@smalyshev
More tests
b12c8a3
@smalyshev
refactor test
72bdb43
@smalyshev
Unit tests
a4e9f01
@smalyshev
Merge branch 'main' into esql-telemetry
1634ab4
@smalyshev
More tests for telemetry
02f2c7f
@smalyshev
More tests
5bd9438
@smalyshev
Update changelog
550107e
@smalyshev
Update docs
7cd62b0
@smalyshev
Add REST YAML test
fce04d5
@smalyshev
Merge branch 'main' into esql-telemetry
f1e7ed8
@smalyshev
fix test
7ea40d8
@smalyshev
Move REST test
402b9a6
@smalyshev
Merge branch 'main' into esql-telemetry
59ccda8
@smalyshev
Merge branch 'main' into esql-telemetry
58a72e1
@smalyshev
Merge branch 'main' into esql-telemetry
8ea56da
@smalyshev
Pull feedback
0ac116e
@smalyshev
Add capabilities check for rest test
ef59b3d
@smalyshev smalyshev requested a review from quux00 January 2, 2025 18:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Documentation preview:

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 2, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Jan 2, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @smalyshev, I've created a changelog YAML for you.

@smalyshev smalyshev added needs:triage Requires assignment of a team area label v8.18.0 auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) and removed Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) needs:triage Requires assignment of a team area label labels Jan 2, 2025
marciw
marciw reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small drive-by style/clarity comments for stats.asciidoc only

quux00
quux00 approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@quux00 quux00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approval after Close/Reopen of PR.

marciw
marciw reviewed Jan 2, 2025
View reviewed changes
marciw
marciw approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs LGTM

@smalyshev smalyshev merged commit 0292905 into elastic:main Jan 2, 2025
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 119474

@smalyshev smalyshev mentioned this pull request Jan 2, 2025
Merged
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Jan 2, 2025
@smalyshev
Add ESQL telemetry collection (elastic#119474)
baae609 
* Add ESQL telemetry collection

(cherry picked from commit 0292905)

# Conflicts:
#	server/src/main/java/org/elasticsearch/TransportVersions.java
elasticsearchmachine pushed a commit that referenced this pull request Jan 2, 2025
@smalyshev
Add ESQL telemetry collection (#119474) (#119479)
4012aec 
* Add ESQL telemetry collection

(cherry picked from commit 0292905)

# Conflicts:
#	server/src/main/java/org/elasticsearch/TransportVersions.java
@idegtiarenko idegtiarenko mentioned this pull request Jan 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marciw marciw marciw approved these changes

@quux00 quux00 quux00 approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smalyshev @elasticsearchmachine @marciw @quux00