-
Notifications
You must be signed in to change notification settings - Fork 25.4k
Remove ChunkedToXContentBuilder #119310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ChunkedToXContentBuilder #119310
Conversation
This reverts commit 918a9cc.
…ToXContentBuilder (elastic#114319)" This reverts commit 8c37875
…lastic#113125)" This reverts commit 11c2eb2
…lastic#112389)" This reverts commit c311515
Pinging @elastic/es-search (Team:Search) |
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Hi @original-brownbear, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (assuming CI is happy anyway)
I haven't really contemplated alternatives, but I honestly don't think the API based around Iterator
is meaningfully harder to use (or read) than the builder-based one. It seemed a little neater at the outset but clearly has performance issues that aren't easy to solve, and we can't reasonably keep such a significant regression in place simply for fairly subjective code-aesthetics reasons even while we work towards an eventual solution that is both performant and pleasing.
Thanks David! |
@original-brownbear This has not been backported to 8.x... |
Reverts the introduction of the
ChunkedToXContentBuilder
to fix the various performance regressions it introduced and the theoretical impossibility of fixing its performance to rival that of the iterator based solution.With the exception of a few minor adjustments that came out of changes already made on top of the builder migration this simply returns to the previous implementations (and some of the stuff in that code could be done better with the utilities available now).
I also verified that this solves the performance issues that we've been running into with the builder.
closes #118647