-
Notifications
You must be signed in to change notification settings - Fork 25.4k
Update sparse text embeddings API route for Inference Service #118025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sparse text embeddings API route for Inference Service #118025
Conversation
Hi @demjened, I've created a changelog YAML for you. |
Pinging @elastic/search-inference-team (Team:Search - Inference) |
Pinging @elastic/search-eng (Team:SearchOrg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold on a minute, are we sure we want the task type to be different to the Inference API? It is called sparse_embedding
there.
@maxjakob IMO there is no need for the downstream Inference Service path to match the path of the Inference API - that's an implementation detail in the model class. Also, we're adding So in EIS we can adopt either naming pattern as long as we're consistent. |
💔 Backport failed
You can use sqren/backport to manually backport by running |
Per discussion with the Search Inference team, we're modifying the API path of ELSER embeddings in Elastic Inference Service:
/api/v1/sparse-text-embedding/ELSERv2
->/api/v1/sparse-text-embedding*s*/ELSERv2
.