Skip to content

Update sparse text embeddings API route for Inference Service #118025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

demjened
Copy link
Contributor

@demjened demjened commented Dec 4, 2024

Per discussion with the Search Inference team, we're modifying the API path of ELSER embeddings in Elastic Inference Service: /api/v1/sparse-text-embedding/ELSERv2 -> /api/v1/sparse-text-embedding*s*/ELSERv2.

@demjened demjened added >enhancement auto-backport Automatically create backport pull requests when merged :SearchOrg/Inference Label for the Search Inference team v9.0.0 v8.16.2 v8.17.1 v8.18.0 labels Dec 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @demjened, I've created a changelog YAML for you.

@demjened demjened requested review from maxjakob and timgrein December 4, 2024 20:30
@demjened demjened marked this pull request as ready for review December 4, 2024 21:38
@elasticsearchmachine elasticsearchmachine added Team:SearchOrg Meta label for the Search Org (Enterprise Search) Team:Search - Inference labels Dec 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-inference-team (Team:Search - Inference)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

Copy link
Contributor

@maxjakob maxjakob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on a minute, are we sure we want the task type to be different to the Inference API? It is called sparse_embedding there.

@demjened
Copy link
Contributor Author

demjened commented Dec 5, 2024

@maxjakob IMO there is no need for the downstream Inference Service path to match the path of the Inference API - that's an implementation detail in the model class. Also, we're adding /api/v1/chat/completions in EIS which is plural on purpose so that it mirrors OpenAI's spec. It's also more RESTful (resources are plural).

So in EIS we can adopt either naming pattern as long as we're consistent.

@demjened demjened requested a review from maxjakob December 6, 2024 16:33
@demjened demjened merged commit 8aa49d9 into elastic:main Dec 10, 2024
16 checks passed
@demjened demjened deleted the demjened/inference-service-elser-api-route branch December 10, 2024 16:48
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.16 Commit could not be cherrypicked due to conflicts
8.17 Commit could not be cherrypicked due to conflicts
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 118025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :SearchOrg/Inference Label for the Search Inference team Team:Search - Inference Team:SearchOrg Meta label for the Search Org (Enterprise Search) v8.16.2 v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants