-
Notifications
You must be signed in to change notification settings - Fork 25.4k
fix/SearchStatesIt_failures #117618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/SearchStatesIt_failures #117618
Conversation
Hi @drempapis, I've created a changelog YAML for you. |
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
@javanna Is this approach enough to merge the muted tests for v9.0.0 and v8.18.0? |
@@ -87,7 +87,7 @@ static List<HttpHost> parseHosts(String props) { | |||
} | |||
|
|||
public static void configureRemoteClusters(List<Node> remoteNodes) throws Exception { | |||
assertThat(remoteNodes, hasSize(3)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think assertBusy
will help you here? The list is just created one by a call to getNodes(..
so it won't ever change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I added the ensureHealth with a timeout to verify that all three nodes are up and running before requesting the nodes' state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if CI's happy I'm happy :) thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One second I'm a little unsure here, discussing in Slack
In this pr #116577, the |
Hi @drempapis, I've updated the changelog YAML for you. |
💔 Backport failed
You can use sqren/backport to manually backport by running |
This will backport the following commits from main to 8.x: #117618
We manually backported changes to v8.18.0 #117729 |
It seems that there is a race condition where this call does not pick up all three nodes that this assert is expecting.
To mitigate and test the issue, I added an "assertBusy" busy spin in the nodes lookup, waiting until all three nodes appear.
Solves #116617 and #116618