Skip to content

Change Reindexing metrics unit from millis to seconds #115721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2024
Merged

Change Reindexing metrics unit from millis to seconds #115721

merged 2 commits into from
Oct 28, 2024

Conversation

ankikuma
Copy link
Contributor

A very small change to fix the units for reindexing took time. It is collected in seconds not milliseconds.

@elasticsearchmachine elasticsearchmachine added v9.0.0 needs:triage Requires assignment of a team area label labels Oct 26, 2024
@ankikuma ankikuma added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >enhancement and removed needs:triage Requires assignment of a team area label v9.0.0 labels Oct 26, 2024
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Oct 26, 2024
@ankikuma ankikuma added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Oct 26, 2024
@elasticsearchmachine elasticsearchmachine removed the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Oct 26, 2024
@ankikuma ankikuma added v9.0.0 :Distributed Indexing/Reindex Issues relating to reindex that are not caused by issues further down labels Oct 26, 2024
@elasticsearchmachine elasticsearchmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. and removed needs:triage Requires assignment of a team area label labels Oct 26, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine
Copy link
Collaborator

Hi @ankikuma, I've created a changelog YAML for you.

henningandersen
henningandersen approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankikuma ankikuma merged commit 0e184af into elastic:main Oct 28, 2024
16 checks passed
ioanatia pushed a commit to ioanatia/elasticsearch that referenced this pull request Nov 4, 2024
@ankikuma @ioanatia
Change Reindexing metrics unit from millis to seconds (elastic#115721)
acad9e9 
Fix the units for reindexing took time metrics from milliseconds to seconds.
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
@ankikuma @jfreden
Change Reindexing metrics unit from millis to seconds (elastic#115721)
7f99617 
Fix the units for reindexing took time metrics from milliseconds to seconds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henningandersen henningandersen henningandersen approved these changes

Assignees
No one assigned
Labels
:Distributed Indexing/Reindex Issues relating to reindex that are not caused by issues further down >enhancement Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankikuma @elasticsearchmachine @henningandersen