Skip to content

Preserve thread context when waiting for segment generation in RTG #114623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2024
Merged

Preserve thread context when waiting for segment generation in RTG #114623

merged 3 commits into from
Oct 14, 2024

Conversation

pxsalehi
Copy link
Member

@pxsalehi pxsalehi commented Oct 11, 2024 •
edited
Loading

This was causing the following failure in ES|QL tests:

HeapAttackIT > testSortByManyLongsTooMuchMemoryAsync FAILED
    org.elasticsearch.client.ResponseException: method [GET], host [http://[::1]:52514], URI [/_query/async/FnBKejZONENPUnFxSk9uT0dMdkd5VmcZTVdhaWxCVmRUNjJwZ2p2dGxsa3FVZzo3MA==], status line [HTTP/1.1 403 Forbidden]
    {"error":{"root_cause":[{"type":"security_exception","reason":"no indices permissions found"}],"type":"security_exception","reason":"no indices permissions found"},"status":403}

Closes ES-9778

@pxsalehi pxsalehi added >bug :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. labels Oct 11, 2024
@elasticsearchmachine elasticsearchmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v9.0.0 labels Oct 11, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine
Copy link
Collaborator

Hi @pxsalehi, I've created a changelog YAML for you.

henningandersen
henningandersen approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

jakelandis
jakelandis approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pxsalehi
Copy link
Member Author

@elasticmachine update branch

@pxsalehi pxsalehi merged commit 2f09fb6 into elastic:main Oct 14, 2024
16 checks passed
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Oct 14, 2024
@pxsalehi @davidkyle
Preserve thread context when waiting for segment generation in RTG (e…
756da0b 
…lastic#114623)

Closes ES-9778
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
@pxsalehi @georgewallace
Preserve thread context when waiting for segment generation in RTG (e…
c7a5da4 
…lastic#114623)

Closes ES-9778
@pxsalehi pxsalehi mentioned this pull request Nov 20, 2024
Merged
elasticsearchmachine pushed a commit that referenced this pull request Nov 22, 2024
@pxsalehi
Preserve thread context when waiting for segment generation in RTG (#…
bcb29b7 
…117148)

The multi-get counterpart of
#114623.
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Nov 22, 2024
@pxsalehi @smalyshev
Preserve thread context when waiting for segment generation in RTG (e…
8ec8e1b 
…lastic#117148)

The multi-get counterpart of
elastic#114623.
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
@pxsalehi @alexey-ivanov-es
Preserve thread context when waiting for segment generation in RTG (e…
95da5f8 
…lastic#117148)

The multi-get counterpart of
elastic#114623.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelandis jakelandis jakelandis approved these changes

@henningandersen henningandersen henningandersen approved these changes

@albertzaharovits albertzaharovits Awaiting requested review from albertzaharovits

Assignees
No one assigned
Labels
>bug :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pxsalehi @elasticsearchmachine @jakelandis @henningandersen @elasticmachine