Skip to content

ESQL - enabling scoring with METADATA _score #113120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 167 commits into from
Nov 28, 2024
Merged

ESQL - enabling scoring with METADATA _score #113120

merged 167 commits into from
Nov 28, 2024

Conversation

tteofili
Copy link
Contributor

@tteofili tteofili commented Sep 18, 2024 •
edited by ChrisHegarty
Loading

This PR adds the _score column to the ES|QL query results, when METADATA _score is specified.

e.g.

FROM logs METADATA _score | WHERE content:"foo"

Adding the METADATA _score directive has no effect on sort order. If sorting by relevance is required, an explicit | SORT _score DESC can be added.

@tteofili tteofili marked this pull request as ready for review September 20, 2024 09:45
@tteofili tteofili requested a review from a team as a code owner September 20, 2024 09:45
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Sep 20, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @tteofili, I've created a changelog YAML for you.

@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) and removed needs:triage Requires assignment of a team area label labels Sep 20, 2024
This was referenced Nov 27, 2024
Closed
Open
@tteofili tteofili merged commit 146cb39 into elastic:main Nov 28, 2024
16 checks passed
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
@tteofili @ChrisHegarty @alexey-ivanov-es
ESQL - enabling scoring with METADATA _score (elastic#113120)
ac5dc6a 
* ESQL - enabling scoring with METADATA _score
Co-authored-by: ChrisHegarty <[email protected]>
tteofili added a commit to tteofili/elasticsearch that referenced this pull request Nov 29, 2024
@tteofili
ESQL - enabling scoring with METADATA _score (elastic#113120)
6367d8f 
* ESQL - enabling scoring with METADATA _score
Co-authored-by: ChrisHegarty <[email protected]>
@tteofili tteofili mentioned this pull request Nov 29, 2024
Merged
tteofili added a commit that referenced this pull request Nov 29, 2024
@tteofili
Backport scoring support in ES|QL to 8.x branch (#117747)
8fcf280 
* ESQL - enabling scoring with METADATA _score (#113120)
* ESQL - enabling scoring with METADATA _score
Co-authored-by: ChrisHegarty <[email protected]>

* Update docs/changelog/117747.yaml

* minor fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpintea bpintea bpintea left review comments

@ChrisHegarty ChrisHegarty ChrisHegarty left review comments

@ioanatia ioanatia ioanatia approved these changes

@fang-xing-esql fang-xing-esql Awaiting requested review from fang-xing-esql

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tteofili @elasticsearchmachine @ChrisHegarty @bpintea @ioanatia @fang-xing-esql