Handle new aggregation range types Pythonically #2860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a142b43 to
70ecf89
Compare
70ecf89 to
50cd220
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Mar 31, 2025
(cherry picked from commit a224f49)
miguelgrinberg
added a commit
that referenced
this pull request
Apr 1, 2025
(cherry picked from commit a224f49) Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the DSL code generator work with the new aggregation range types introduced in elastic/elasticsearch-specification#2725. Basically this change makes the generator ignore these types and use a manually added one in wrappers.py, exactly like ranges are handled for queries.
In addition, I have changed the way the DSL generator determines which version of the schema to use, because the main branch reports 8.17.2 as current version. With this change we are using the git branch instead of the version reported in the code. And some schema changes that are unrelated to aggregation ranges are also included.