This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Implement async contest manager interface on AsyncElasticsearch #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features: - updated README with the new syntax (first example) - test code in a separate file, because it has to use Python 3.5+ syntax
|
@karmi I have done so now! Sorry about the confusion. |
|
Is this still WIP? |
|
@3lnc No! Thanks for pinging me; I had forgotten to remove the WIP tag. Also, ping @karmi |
|
hate to plus one but.. +1 |
|
Nice feature, thank you! Ping @karmi one more time. |
|
Cool, I see the checks are green now. @fxdgear or @honzakral , can you have a look at the PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
Closes: #48