Add ECE version attributes #2997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
kilfoyle
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2996
The
ece-refshared attribute is currently set to thecurrentURL, which is problematic if we have to revert the "current" version or link to topics that don't exist incurrentyet.Since we need to move away from the book-scoped
ece-versionvariables anyway, this PR adds ECE version files similarly to the Stack version files. Unlike those stack versions, however, the branch names in ECE do not match the version numbers so it is a little trickier to resolve the file names.I've used a
ece-link-versionin the sharedece-refvariable rather than the actualece-versionsince I don't want to potentially break things in the old releases. This way all but the latest releases can still link to "current".