Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude unecessary resources after services have been selected #11978

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jul 9, 2024

What I did
remove definition for unused resources after services have been selected
includes e2e test to avoid a future regression with this feature

Related issue
fixes #11976

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@ndeloof ndeloof requested review from a team, glours and jhrotko and removed request for a team July 9, 2024 07:34
@ndeloof ndeloof force-pushed the unecessary_resources branch 3 times, most recently from affd090 to 66de94e Compare July 9, 2024 11:56
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 25f8593 into docker:main Jul 9, 2024
30 checks passed
@ndeloof ndeloof deleted the unecessary_resources branch July 9, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] docker compose up service fails because of required network from another service
2 participants