-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add open watch docs in up menu #11917
Conversation
c69070a
to
ffbc204
Compare
cmd/formatter/shortcut.go
Outdated
watchInfo = navColor(" ") | ||
} | ||
var isEnabled = " Enable" | ||
if lk.Watch.Watching { | ||
isEnabled = " Disable" | ||
} | ||
watchInfo = watchInfo + shortcutKeyColor("w") + navColor(isEnabled+" Watch") | ||
return openDDInfo + openDDUI + watchInfo | ||
return openDDInfo + openDDUI + watchInfo + openDDWatchDocs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add all openDD in order?
cmd/formatter/shortcut.go
Outdated
@@ -314,6 +333,8 @@ func (lk *LogKeyboard) HandleKeyEvents(event keyboard.KeyEvent, ctx context.Cont | |||
lk.StartWatch(ctx, doneCh, project, options) | |||
case 'o': | |||
lk.openDDComposeUI(ctx, project) | |||
case 'i': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Joana Hrotko <[email protected]>
ffbc204
to
1d290d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What I did
Add Watch docs option in menu to open Watch documentation in Docker Desktop
Related issue
https://docker.atlassian.net/browse/COMP-624?atlOrigin=eyJpIjoiYWRhZDc0NzQ3YjU3NGQxYzg1Zjk0NWM0MDY2ZmQ1YmUiLCJwIjoiaiJ9
(not mandatory) A picture of a cute animal, if possible in relation to what you did