chore(e2e): fix flaky cascade failure test #11739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This was racy with the sleep, so the Compose file has been tweaked to make it pass reliably.
Now, there's 3 services:
running
- sleeps foreverexit
- exits successfully immediatelyrunning
startedfail
- exits with error immediatelyexit
succeedingNow, the test can ensure that the containers are all run/ started in the expected order the assertions will be reliable.
Before, it was possible for
fail
to run & exit beforeexit
, for example. Therunning
service also ensures there's always at least one other "running" container when we do an abort.Related issue
n/a, just my failing CI jobs
(not mandatory) A picture of a cute animal, if possible in relation to what you did
![baby cheetah](https://private-user-images.githubusercontent.com/841263/323274761-c0f8e567-3189-4a55-a652-9291aa0be4dc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwOTEwMTQsIm5iZiI6MTcyNjA5MDcxNCwicGF0aCI6Ii84NDEyNjMvMzIzMjc0NzYxLWMwZjhlNTY3LTMxODktNGE1NS1hNjUyLTkyOTFhYTBiZTRkYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMVQyMTM4MzRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03NWFjMmNlNzY2ZGY4Njk4MGIxMWQzNzQ0ZWRjMzY4YmE1YTQxZGQ0NjhjYzIwMGEwOWRkYjgwYmEwMmUwYjdhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.F0hmGsPsGRz7iFU4l-njXiW1X7MrvB8Pa2xy5uTjfco)