fix: do not try to create file shares for non-directories #11738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When creating automatic file shares, ignore any non-directory bind mounts, e.g. for an individual (normal) file or a special type like a Unix socket (
/var/run/docker.sock
).Additionally, there's no need to create a directory if one does not exist, the API will handle that. However, the check for existence remains so that
create_host_path: false
mounts can be ignored.Related issue
https://docker.atlassian.net/browse/COMP-515
(not mandatory) A picture of a cute animal, if possible in relation to what you did
![black squirrel](https://private-user-images.githubusercontent.com/841263/323231740-4177e6cb-a5af-49d3-aa0a-01eb851036cf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwOTA1NDUsIm5iZiI6MTcyNjA5MDI0NSwicGF0aCI6Ii84NDEyNjMvMzIzMjMxNzQwLTQxNzdlNmNiLWE1YWYtNDlkMy1hYTBhLTAxZWI4NTEwMzZjZi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMVQyMTMwNDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wZWRlYmZjYzEwMTFjZWVhMmExNTdlZjQyMjk0NjcxMzQxZWU2MTUyMjY3MzNhNzQ0MWJkZWFkNjA1YzYxZDEzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.eV0mFifR3IPKBY35tYnuC-_jE0g9uL3HEQFh_iF0gpo)