don't clear line when navigation is disabled #11733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Quick and dirty fix for #11727 : only emit
ERASE
whenKeyboardManager
is set, which reflects navigation menu being enabled.We should invest some time to redesign the log printing logic, so that
logConsumer
is not a weird combination ofif
statements.Related issue
fixes #11727
(not mandatory) A picture of a cute animal, if possible in relation to what you did
![image](https://private-user-images.githubusercontent.com/132757/322797177-bca7daa5-70e7-4353-9e20-6ed7ca24f3d8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwOTIwODYsIm5iZiI6MTcyNjA5MTc4NiwicGF0aCI6Ii8xMzI3NTcvMzIyNzk3MTc3LWJjYTdkYWE1LTcwZTctNDM1My05ZTIwLTZlZDdjYTI0ZjNkOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMVQyMTU2MjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01MGEwNDBiOGFmNzI4ZTYyZjJkNGRiODE1NzY0YmY1MTg3NzFkYTQ4MWMyMjU5MDE1ZGVhZTAwZTZlZjNkNGZmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.pw88ZGPAnH75OuqTc6LStBmaxP4g10UdQApB1CiC-2I)