Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use ansi espace sequence when disabled #11682

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Apr 3, 2024

What I did
when ansi is disabled or output is not a terminal, fully disable any ANSI magic

Related issue
closes #11681

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@ndeloof ndeloof requested a review from jhrotko April 3, 2024 10:19
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 54.25%. Comparing base (ff20b64) to head (fbfb065).

Files Patch % Lines
cmd/formatter/ansi.go 11.11% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11682      +/-   ##
==========================================
- Coverage   54.57%   54.25%   -0.33%     
==========================================
  Files         145      145              
  Lines       12605    12630      +25     
==========================================
- Hits         6879     6852      -27     
- Misses       5037     5086      +49     
- Partials      689      692       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lms-jk
Copy link

lms-jk commented Apr 3, 2024

Can confirm that this patch will resolve #11681. Thank you!

@ndeloof ndeloof merged commit d71d8bc into docker:main Apr 3, 2024
30 checks passed
@ndeloof
Copy link
Contributor Author

ndeloof commented Apr 3, 2024

Let's merge this with this quick and dirty fix, will need to revisit the formatter package at some point as this becomes spaghetti code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] systemd-journald recognizes logs as blob
4 participants