Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: docker/compose
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.20.1
Choose a base ref
...
head repository: docker/compose
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.20.2
Choose a head ref
  • 16 commits
  • 30 files changed
  • 4 contributors

Commits on Jul 18, 2023

  1. add support of depends_on.required attribute

    Signed-off-by: Guillaume Lours <[email protected]>
    glours committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    bb94ea0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2d16a05 View commit details
    Browse the repository at this point in the history
  3. test: skip watch e2e test on macOS for the moment

    Fix forthcoming via compose-spec/compose-go#436
    which addresses some symlink limitations. These can
    actually effect other platforms but are most common
    on macOS because the test creates temporary directories,
    which are symlinked on macOS.
    
    Signed-off-by: Milas Bowman <[email protected]>
    milas committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    d48f28c View commit details
    Browse the repository at this point in the history
  4. test: do not run watch e2e tests in parallel

    This isn't playing nicely with the GHA CI runner.
    
    Signed-off-by: Milas Bowman <[email protected]>
    milas committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    ddceb1a View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Merge pull request #10792 from glours/add-depends_on-required

    add support of depends_on.required attribute
    glours authored Jul 19, 2023
    1 Configuration menu
    Copy the full SHA
    5a072b1 View commit details
    Browse the repository at this point in the history
  2. build: do not attempt to push unnamed service images

    When building, if images are being pushed, ensure that only
    named images (i.e. services with a populated `image` field)
    are attempted to be pushed.
    
    Services without `image` get an auto-generated name, which
    will be a "Docker library" reference since they're in the
    format `$project-$service`, which is implicitly the same as
    `docker.io/library/$project-$service`. A push for that is
    never desirable / will always fail.
    
    The key here is that we cannot overwrite the `<svc>.image`
    field when doing builds, as we need to be able to check for
    its presence to determine whether a push makes sense.
    
    Fixes #10813.
    
    Signed-off-by: Milas Bowman <[email protected]>
    milas authored and glours committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    636c13f View commit details
    Browse the repository at this point in the history
  3. Merge pull request #10814 from milas/fix-build-push

    build: do not attempt to push unnamed service images
    glours authored Jul 19, 2023
    1 Configuration menu
    Copy the full SHA
    7d88eda View commit details
    Browse the repository at this point in the history
  4. check secret target is an absolute windows path

    Signed-off-by: Nicolas De Loof <[email protected]>
    ndeloof authored and glours committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    47778f8 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #10819 from ndeloof/windows_abs

    check secret target is an absolute windows path
    glours authored Jul 19, 2023
    1 Configuration menu
    Copy the full SHA
    3b2f3cd View commit details
    Browse the repository at this point in the history
  6. trace: instrument compose up at a high-level

    * Image pull
    * Image build
    * Service apply
      * Scale down/up (event)
      * Recreate container (event)
      * Scale up (event)
      * Container start (event)
    
    Signed-off-by: Milas Bowman <[email protected]>
    milas authored and glours committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    1ae191a View commit details
    Browse the repository at this point in the history
  7. Merge pull request #10831 from milas/instrument-up

    trace: instrument `compose up` at a high-level
    glours authored Jul 19, 2023
    1 Configuration menu
    Copy the full SHA
    5159058 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #10829 from milas/e2e-watch-test-fix

    test: watch e2e reliability tweaks
    glours authored Jul 19, 2023
    1 Configuration menu
    Copy the full SHA
    150b88a View commit details
    Browse the repository at this point in the history
  9. pkg/compose: RunOneOffContainer: don't use NewStartOptions()

    It's no longer used in docker/cli, and doesn't do anything other than
    creating an empty struct, so replacing it (as we're planning to
    deprecate that function)
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah authored and glours committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    4eb43c5 View commit details
    Browse the repository at this point in the history
  10. Merge pull request #10828 from thaJeztah/minor_cli_changes

    pkg/compose: RunOneOffContainer: don't use NewStartOptions()
    glours authored Jul 19, 2023
    1 Configuration menu
    Copy the full SHA
    9174a99 View commit details
    Browse the repository at this point in the history
  11. watch: move sync logic into separate package

    Just moving some code around in preparation for an alternative
    sync implementation that can do bulk transfers by using `tar`.
    
    Signed-off-by: Milas Bowman <[email protected]>
    milas authored and glours committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    cb17c3c View commit details
    Browse the repository at this point in the history
  12. Merge pull request #10791 from milas/watch-refactor-sync

    watch: move sync logic into separate package
    glours authored Jul 19, 2023
    1 Configuration menu
    Copy the full SHA
    8318f66 View commit details
    Browse the repository at this point in the history
Loading