Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken function get_current_style in Styles subsystem #2090

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

hohfchns
Copy link
Contributor

Function contained code with invalid syntax, and wrong variable return.
New code calls the method appropriately and makes a check for validity of the retrieved style.

Copy link
Collaborator

@CakeVR CakeVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request!

While I prefer if @Jowan-Spooner can evaluate the validity of this PR, I requested a small improvement.

addons/dialogic/Modules/Style/subsystem_styles.gd Outdated Show resolved Hide resolved
@Jowan-Spooner Jowan-Spooner merged commit 5cfbbee into dialogic-godot:main Feb 19, 2024
2 checks passed
@Jowan-Spooner
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants