Multi-fix-PR #1999
Merged
Multi-fix-PR #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invertex
pushed a commit
to Invertex/dialogic
that referenced
this pull request
Jan 26, 2024
* Small fix for StyleLayer resource * Change empty speaker info to string * Add method to open history from code * Change the z_index of simple-highlight-portrait * Fix Speaker highlight loading * Fix for dialogic-godot#1998 * Attempt at fixing dialogic-godot#1993 * Remove old code * Add "Duplicate" item to event right click * Finish History open/close methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry I'm always making a bunch of different changes into a big PR.
This PR attempts to fix a few issues and does some other minor tweaks I've found necessary while experimenting.
Add methods Dialogic.History.open_history() and Dialogic.History.close_history() that will emit open_requested and close_requested signals for any history layer to listen too (the default one does so now). fixes A method for opening/closing the History #1979
fix for Error if the first Text Event has no speaker #1998
fix for Issue reparenting a nested Choice event #1993
fix for Add duplicate option in the event right click menu #1994