Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore loading a save when using Styles (#1959) #1960

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Restore loading a save when using Styles (#1959) #1960

merged 2 commits into from
Dec 19, 2023

Conversation

sudisk
Copy link
Contributor

@sudisk sudisk commented Dec 17, 2023

Fixes #1959

@Jowan-Spooner
Copy link
Collaborator

Thanks. The fixes look reasonable. I will test them tomorrow after I got back home.

@Jowan-Spooner
Copy link
Collaborator

Thanks! I adjusted the code a little, mainly to follow the gd-script styleguide and to make it a bit simpler.

@Jowan-Spooner Jowan-Spooner merged commit 3e90442 into dialogic-godot:main Dec 19, 2023
@sudisk
Copy link
Contributor Author

sudisk commented Dec 20, 2023

Thank you for accepting my proposed changes. Your version looks much cleaner.

Invertex pushed a commit to Invertex/dialogic that referenced this pull request Jan 26, 2024
@sudisk @Jowan-Spooner @Invertex
Restore loading a save when using Styles (dialogic-godot#1959) (dialo…
ab88c8d 
…gic-godot#1960)

* Restore loading a save when using Styles (dialogic-godot#1959)

Restore load functionality.

* Small adjustments

---------

Co-authored-by: Jowan-Spooner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using Styles, loading a save doesn't complete
2 participants
@sudisk @Jowan-Spooner