Fix skip delay of 0 and add short input block after natural text finish #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip delay of 0 wasn't working because timers don't accept a wait time of 0.
I also converted the skip_delay_timer to a more general input_block_timer.
I also added a 0.1 second input block when text finishes naturally. This is useful as often (for short texts) you think you want to reveal the full text, but then when you click it already finished revealing and you go to the next event. Hopefully this helps prevent this, by giving a short moment to realize the text finished (as indicated by the next inidicator).