Silence error on get_meta(..., null) #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the `Object` docs, providing a default value of `null` to the `get_meta` call doesn't silence the error in the event that the metadata key doesn't exist. We have a few instances of this pattern throughout the codebase, which were producing unintended error messages under certain circumstances. This commit replaces them with explicit `has_meta` checks, where appropriate. In situations where the null value should be an error (typically because it was previously checked) I removed the default argument, to avoid confusion (the behavior is the same). Also did some boy scout rule cleanup of trailing whitespace and refactored some confusing branch logic in `DialogicGameHandler.gd`.
coppolaemilio
approved these changes
Jul 22, 2023
|
@Jowan-Spooner want to take a look? looks good to me |
|
Generally looks good to me as well. I'm still traveling and access to internet is rare so I can't trst it. I'll be properly back on Friday or Saturday. But this looks like it can be merged. |
|
Thank you @oddfacade ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the
Objectdocs, providing a default value ofnullto theget_metacall doesn't silence the error in the event that the metadata key doesn't exist. We have a few instances of this pattern throughout the codebase, which were producing unintended error messages under certain circumstances.This commit replaces them with explicit
has_metachecks, where appropriate. In situations where the null value should be an error (typically because it was previously checked) I removed the default argument, to avoid confusion (the behavior is the same).Also did some boy scout rule cleanup of trailing whitespace and refactored some confusing branch logic in
DialogicGameHandler.gd.