Big signal update #1502
Merged
Big signal update #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added many signals to all the subsystems. Most of these just give one info dictionary argument. While this is initally not as nice as giving named arguments, it means we can way more easily provide mode information in the future without breaking any code. Added signals: - Voice: voiceline_started, voiceline_finished, voiceline_stopped - Variable: variable_changed, variable_was_set - TextInput: input_confirmed, input_shown - Text: text_finished, speaker_updated, textbox_visibility_changed - Style: style_changed - Jump: switched_timeline, jumped_to_label, returned_from_jump - Choices: choice_selected, choices_shown - Portraits: character_joined, character_left, character_portrait_changed, character_moved, position_changed - Background: background_changed - Audio: music_started, sound_started Also: - removed the voice timer from the voice subsystem - fixed typo in Jump.resume_from_last_jump()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added many signals to all the subsystems.
Most of these just give one info dictionary argument. While this is initally not as nice as giving named arguments, it means we can way more easily provide mode information in the future without breaking any code.
Added signals:
Also:
Fixes/Helps with: