Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocolor names and a glossary display bug #1926

Closed
coppolaemilio opened this issue Nov 28, 2023 · 0 comments · Fixed by #1933
Closed

Autocolor names and a glossary display bug #1926

coppolaemilio opened this issue Nov 28, 2023 · 0 comments · Fixed by #1933
Labels
Bug 🐞 Something isn't working

Comments

@coppolaemilio
Copy link
Collaborator

If you have the setting "Autocolor names" enabled and a character shares the same name as a glossary entry, there is an error in how they are displayed. This also results in the glossary popup not showing when hovering the name.

image

@coppolaemilio coppolaemilio added the Bug 🐞 Something isn't working label Nov 28, 2023
Jowan-Spooner added a commit that referenced this issue Dec 2, 2023
- Fixes #1926
Adds a system for color-overrides to the glossary. This is used so character colors have a higher priority than glossary colors.

Makes it so that when a glossary is hovered the input is consumed.
Invertex pushed a commit to Invertex/dialogic that referenced this issue Jan 26, 2024
- fixes dialogic-godot#1890
- fixes dialogic-godot#1896
- fixes/implements dialogic-godot#1903
- fixes/implements dialogic-godot#1310
- fixes dialogic-godot#1907
- fixes dialogic-godot#1926

# Bigger changes
- Makes it so when a glossary is hovered all dialogic input is blocked.
- Moves Portrait Z-index to a tree-order based system that sorts the portrait containers. This simplifies layout setups. Discussed on discord.
- removes old files/folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant