Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My dialogue crashes when a character spawns with "At the position" greater than 4. #1474

Closed
EmmanuelHuazo opened this issue Mar 19, 2023 · 1 comment · Fixed by #1524
Closed
Labels
Bug 🐞 Something isn't working Noob Friendly 👍 Good for newcomers UI/UX ✏

Comments

@EmmanuelHuazo
Copy link

When the value "At the position" in the timeline editor is greater than 5 it crashes my game.

Describe the bug
As I already said, I was playing with the positions that the character can have and I discovered that if a character uses a value greater than 4 (5,6,7,8,9, etc) the game crashes.

Also, it seems that putting a negative value doesn't move the character to the left.

To Reproduce
Steps to reproduce the behaviour:

  1. Just put a value bigger than 4.
  2. I was using 3 characters at once.

Expected behaviour
it crashes.

Screenshots
If applicable, add screenshots to help explain your problem.

System (please complete the following information):

  • OS: Windows 11
  • Godot Version: 4
  • Dialogic Version: alpha 6

Captura de pantalla 2023-03-19 111506
Captura de pantalla 2023-03-19 111542
image

@Jowan-Spooner Jowan-Spooner added Bug 🐞 Something isn't working Noob Friendly 👍 Good for newcomers labels Mar 19, 2023
@Jowan-Spooner
Copy link
Collaborator

This is somewhat "expected" as the default scene only comes with 5 portrait positions.
Ideally there shouldn't be crash, only a warning.

Jowan-Spooner added a commit that referenced this issue Apr 23, 2023
Fix for #1474, by making sure the game doesn't crash, only prints an error when an invalid position index is given.
@Jowan-Spooner Jowan-Spooner linked a pull request Apr 23, 2023 that will close this issue
coppolaemilio pushed a commit that referenced this issue Apr 23, 2023
Fix for #1474, by making sure the game doesn't crash, only prints an error when an invalid position index is given.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working Noob Friendly 👍 Good for newcomers UI/UX ✏
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants