chore(tests): unbreak tests on Windows #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb96969
to
48ea8a4
Compare
48ea8a4
to
67d0521
Compare
Currently [appveyor tests](https://ci.appveyor.com/project/manishrjain/badger/builds/42502297) fail with: ``` --- FAIL: TestOpenDBReadOnly (0.66s) db_test.go:2237: Error Trace: db_test.go:2237 Error: Received unexpected error: Read-only mode is not supported on Windows github.com/dgraph-io/badger/v3.init C:/gopath/src/github.com/dgraph-io/badger/errors.go:94 runtime.doInit C:/go/src/runtime/proc.go:5222 runtime.doInit C:/go/src/runtime/proc.go:5217 runtime.main C:/go/src/runtime/proc.go:190 runtime.goexit C:/go/src/runtime/asm_amd64.s:1357 Test: TestOpenDBReadOnly ```
67d0521
to
25845de
Compare
|
@SaveTheRbtz Thank you for looking into this. I think that we should fix the underlying problem with the Windows build instead of making the tests pass. I would like to get the opinion of the community on this issue before we merge. Please express your opinion. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
|
jarifibrahim
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
The change looks good to me! @SaveTheRbtz we cannot merge the PR without the CLA signed. Can you please sign it?
@akon-dey This PR is fixing issues with windows build. The two tests that are skipped would fail on windows because they're testing a behaviour that's only supported on linux.
It might've taken a lot of effort to fix these tests. Thank you @SaveTheRbtz 🎉
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Signed CLA, merged with |
akon-dey
approved these changes
Dec 11, 2022
|
Thank you for your contribution @SaveTheRbtz ! |
joshua-goldstein
pushed a commit
that referenced
this pull request
Dec 16, 2022
Currently [appveyor tests](https://ci.appveyor.com/project/manishrjain/badger/builds/42502297) are failing in multiple places on Windows. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/dgraph-io/badger/1775) <!-- Reviewable:end --> (cherry picked from commit 41a2397)
joshua-goldstein
pushed a commit
that referenced
this pull request
Dec 16, 2022
Currently [appveyor tests](https://ci.appveyor.com/project/manishrjain/badger/builds/42502297) are failing in multiple places on Windows. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/dgraph-io/badger/1775) <!-- Reviewable:end --> (cherry picked from commit 41a2397)
joshua-goldstein
added a commit
that referenced
this pull request
Dec 16, 2022
Currently [appveyor tests](https://ci.appveyor.com/project/manishrjain/badger/builds/42502297) are failing in multiple places on Windows. Original PR #1775 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/dgraph-io/badger/1775) <!-- Reviewable:end --> <!-- Change Github PR Title Your title must be in the following format: - `topic(Area): Feature` - `Topic` must be one of `build|ci|docs|feat|fix|perf|refactor|chore|test` Sample Titles: - `feat(Enterprise)`: Backups can now get credentials from IAM - `fix(Query)`: Skipping floats that cannot be Marshalled in JSON - `perf: [Breaking]` json encoding is now 35% faster if SIMD is present - `chore`: all chores/tests will be excluded from the CHANGELOG --> ## Problem <!-- Please add a description with these things: 1. Explain the problem by providing a good description. 2. If it fixes any GitHub issues, say "Fixes #GitHubIssue". 3. If it corresponds to a Jira issue, say "Fixes DGRAPH-###". 4. If this is a breaking change, please prefix `[Breaking]` in the title. In the description, please put a note with exactly who these changes are breaking for. --> ## Solution <!-- Please add a description with these things: 1. Explain the solution to make it easier to review the PR. 2. Make it easier for the reviewer by describing complex sections with comments. --> Co-authored-by: Alexey Ivanov <[email protected]> Co-authored-by: Joshua Goldstein <[email protected]>
joshua-goldstein
pushed a commit
that referenced
this pull request
Feb 13, 2023
Currently [appveyor tests](https://ci.appveyor.com/project/manishrjain/badger/builds/42502297) are failing in multiple places on Windows. Original PR #1775 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/dgraph-io/badger/1775) <!-- Reviewable:end --> <!-- Change Github PR Title Your title must be in the following format: - `topic(Area): Feature` - `Topic` must be one of `build|ci|docs|feat|fix|perf|refactor|chore|test` Sample Titles: - `feat(Enterprise)`: Backups can now get credentials from IAM - `fix(Query)`: Skipping floats that cannot be Marshalled in JSON - `perf: [Breaking]` json encoding is now 35% faster if SIMD is present - `chore`: all chores/tests will be excluded from the CHANGELOG --> ## Problem <!-- Please add a description with these things: 1. Explain the problem by providing a good description. 2. If it fixes any GitHub issues, say "Fixes #GitHubIssue". 3. If it corresponds to a Jira issue, say "Fixes DGRAPH-###". 4. If this is a breaking change, please prefix `[Breaking]` in the title. In the description, please put a note with exactly who these changes are breaking for. --> ## Solution <!-- Please add a description with these things: 1. Explain the solution to make it easier to review the PR. 2. Make it easier for the reviewer by describing complex sections with comments. --> Co-authored-by: Alexey Ivanov <[email protected]> Co-authored-by: Joshua Goldstein <[email protected]> (cherry picked from commit fba305b)
fredcarle
pushed a commit
to fredcarle/badger
that referenced
this pull request
Aug 1, 2023
Currently [appveyor tests](https://ci.appveyor.com/project/manishrjain/badger/builds/42502297) are failing in multiple places on Windows. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/dgraph-io/badger/1775) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently appveyor tests are failing in multiple places on Windows.
This change is