Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom IBytesToString implementation #1681

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Add custom IBytesToString implementation #1681

merged 2 commits into from
Mar 19, 2021

Conversation

rohanprasad
Copy link
Contributor

@rohanprasad rohanprasad commented Mar 17, 2021 •
edited
Loading

  • Add a custom function that provides logging size up to a decimal place when it's more than 1GiB

Fixes DGRAPH-3186

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ahsanbarkati
ahsanbarkati reviewed Mar 18, 2021
View reviewed changes
y/y.go Outdated Show resolved Hide resolved
NamanJain8
NamanJain8 reviewed Mar 18, 2021
View reviewed changes
y/y.go Outdated Show resolved Hide resolved
@NamanJain8
Copy link
Contributor

@rohanprasad you would have to sign the CLA as well.

@rohanprasad rohanprasad marked this pull request as ready for review March 19, 2021 06:24
@rohanprasad rohanprasad merged commit d66dff2 into master Mar 19, 2021
@rohanprasad rohanprasad deleted the rohanprasad/improve_size_logging branch April 12, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahsanbarkati ahsanbarkati ahsanbarkati left review comments

@NamanJain8 NamanJain8 NamanJain8 approved these changes

@jarifibrahim jarifibrahim Awaiting requested review from jarifibrahim

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rohanprasad @CLAassistant @NamanJain8 @ahsanbarkati