Opt(Table): Keep the cheaper parts of the index within Table struct #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmai
added a commit
to dgraph-io/dgraph
that referenced
this pull request
Dec 3, 2020
Keep the cheaper parts of the index within table struct. (dgraph-io/badger#1608)
danielmai
added a commit
to dgraph-io/dgraph
that referenced
this pull request
Dec 3, 2020
Update Badger to bring in fixes to reduce memory usage during snapshot streaming. dgraph-io/badger@3d225d7...70088c6 - Keep the cheaper parts of the index within table struct. (dgraph-io/badger#1608) - Fix(OOM): Reuse pb.KVs in Stream (dgraph-io/badger#1609)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even for some integer fields like MaxVersion, KeyCount, OffsetsLength, we end up calling
fetchIndex, which hits Ristretto cache. Instead, we could just keep these in memory always, because they're so cheap. This PR does that.This change is