Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt: Small memory usage optimizations #1562

Merged
merged 4 commits into from
Oct 12, 2020
Merged

opt: Small memory usage optimizations #1562

merged 4 commits into from
Oct 12, 2020

Conversation

manishrjain
Copy link
Contributor

@manishrjain manishrjain commented Oct 12, 2020 •
edited
Loading

  • Use z.Calloc for decryption.
  • Copy over biggest and smallest keys, so we don't hold a reference to the much bigger index byte slice.

This change is Reviewable

@manishrjain manishrjain merged commit 2b9b6e9 into master Oct 12, 2020
@manishrjain manishrjain deleted the mrjn/decrypt branch October 12, 2020 23:58
codelingo[bot]
codelingo bot reviewed Oct 13, 2020
View reviewed changes
Copy link

@codelingo codelingo bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 24 rules errored during the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelingo CodeLingo codelingo left review comments

@jarifibrahim jarifibrahim Awaiting requested review from jarifibrahim

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manishrjain