Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Album/playlist track number not being saved #482

Closed
TuTiuTe opened this issue May 24, 2024 · 7 comments
Closed

[BUG] Album/playlist track number not being saved #482

TuTiuTe opened this issue May 24, 2024 · 7 comments
Labels
bug Something isn't working Waiting For Release Implemented but not released yet

Comments

@TuTiuTe
Copy link

TuTiuTe commented May 24, 2024

** Before making an issue make sure you are using the latest version of yt-dlp in the settings. Perhaps try using the nightly version of yt-dlp. If that didn't help, proceed with the issue
I am using the latest version, even switched to the beta version to make sure

Describe the bug
A few months ago, whenever I downloaded a playlist, its songs were numbered in the metadata in the same order as they are in the playlist
Right now, it just doesn't work despite there clearly being the intent to do the same thing as before when checking the logs

To Reproduce
Steps to reproduce the behavior:
Just try to download any playlist, look at their metadata, and they won't be numbered

Expected behavior
The tracks should have been properly numbered in the metadata

Screenshots / Video Recording
The playlist I want to download
Screenshot_20240524-161506_Fennec

Screenshot_20240524-161614_YTDLnis

Here is the log, showing it has set the track number to index 11
image23

Here is a screenshot of the change not actually happening (it's not the same track, but every track doesn't have their track number)
Screenshot_20240524_170943

(please complete the following information):

  • Android Version: 14
  • App Version: tested on 1.7.5 and 1.7.6 beta
@TuTiuTe TuTiuTe added the bug Something isn't working label May 24, 2024
@TuTiuTe TuTiuTe changed the title [BUG] Album/playlist trask number not being saved [BUG] Album/playlist track number not being saved May 24, 2024
@zaednasr
Copy link
Collaborator

Did ytdlp change a command? What is supposed to be the correct one? Because the app knows the playlist index at least

@TuTiuTe
Copy link
Author

TuTiuTe commented May 24, 2024

I looked around a bit in yt-dl's documentation. I managed to embed the right metadata by doing --parse-metadata "playlist_index:%(track_number)s". The log in ytdlnis indicates it does --parse-metadata "%(track_number,playlist_index)d:%(meta_track_number)s"
Since I tried yt-dl on my pc, it might be a different version in ytdlnis and the fix is maybe not as easy as modifying that one line of code

@zaednasr
Copy link
Collaborator

Try copying the apps log and test in terminal mode. Because ytdlp is the same

@TuTiuTe
Copy link
Author

TuTiuTe commented May 24, 2024

it solved the issue in the mobile app when using "track_number" instead of "meta_track_number"

@TuTiuTe
Copy link
Author

TuTiuTe commented May 24, 2024

"meta_track_number" is in line 1174 of /app/src/main/java/com/deniscerri/ytdl/util/InfoUtil.kt
I have barely used git in my life and have no clue on how to make the change myself

@zaednasr zaednasr added the Waiting For Release Implemented but not released yet label May 24, 2024
@zaednasr
Copy link
Collaborator

@TuTiuTe
Copy link
Author

TuTiuTe commented May 26, 2024

Works perfectly thx <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Waiting For Release Implemented but not released yet
Projects
None yet
Development

No branches or pull requests

2 participants