Skip to content

fix: resolve conflicting exception guidance in __dlpack__ #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2025
Merged

fix: resolve conflicting exception guidance in __dlpack__ #887

merged 2 commits into from
Feb 6, 2025

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Jan 23, 2025

This PR:

@kgryte kgryte added topic: DLPack DLPack. Backport Changes involve backporting to previous versions. labels Jan 23, 2025
@kgryte kgryte added this to the v2024 milestone Jan 23, 2025
@kgryte kgryte requested a review from leofang January 23, 2025 02:23
@kgryte kgryte mentioned this pull request Jan 23, 2025
Closed
@kgryte kgryte removed the request for review from leofang February 6, 2025 02:18
@kgryte
Copy link
Contributor Author

kgryte commented Feb 6, 2025

As this is a minor textual change and addresses an oversight, I'll go ahead and merge.

@kgryte kgryte merged commit b0aacd9 into data-apis:main Feb 6, 2025
3 checks passed
@kgryte kgryte deleted the fix/dlpack-exception-conflict branch February 6, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backport Changes involve backporting to previous versions. topic: DLPack DLPack.
Projects
None yet
Milestone
v2024
Development

Successfully merging this pull request may close these issues.

Minor clarification for conflicting information in __dlpack__
1 participant
@kgryte