Skip to content

fix: address default value regression for axis kwarg in vecdot #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix: address default value regression for axis kwarg in vecdot #880

merged 1 commit into from
Jan 9, 2025

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Jan 9, 2025

This PR:

@kgryte kgryte added the Backport Changes involve backporting to previous versions. label Jan 9, 2025
@kgryte
Copy link
Contributor Author

kgryte commented Jan 9, 2025 •
edited
Loading

As this PR fixes a regression from a previous fix, I'll go ahead and merge. This PR simply makes the defaults consistent between vecdot and linalg.vecdot where the default axis should be -1.

@kgryte kgryte merged commit fd6f507 into data-apis:main Jan 9, 2025
3 checks passed
@kgryte kgryte deleted the fix/vecdot-regression branch January 9, 2025 08:32
@kgryte kgryte added this to the v2024 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backport Changes involve backporting to previous versions.
Projects
None yet
Milestone
v2024
Development

Successfully merging this pull request may close these issues.

xp.linalg.vecdot should have axis=-1 default
1 participant
@kgryte