Skip to content

Backport type fixes to __getitem__ to previous specification revisions #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2023
Merged

Backport type fixes to __getitem__ to previous specification revisions #687

merged 3 commits into from
Nov 6, 2023

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Sep 20, 2023

This PR

  • is a follow-up to Clarify types to allow None in indexing #674, where the changes introduced in that PR are backported to previous specification revisions.
  • as the specification guidance describes the use of None in multi-axis indexing from the 2021 revision onward, the exclusion of None from the typings was an omission. This PR addresses this omission.
  • introduces a short note regarding newaxis which is not mentioned in the indexing document, but should likely be mentioned due to its use as a more literate means for introducing new axes.

@kgryte kgryte added topic: Indexing Array indexing. Backport Changes involve backporting to previous versions. labels Sep 20, 2023
@kgryte kgryte added this to the v2023 milestone Sep 20, 2023
@kgryte kgryte requested a review from honno October 18, 2023 23:25
@kgryte
Copy link
Contributor Author

kgryte commented Oct 18, 2023

@honno Would you mind reviewing?

honno
honno approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@honno honno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kgryte
Copy link
Contributor Author

kgryte commented Nov 6, 2023

As this has gotten the thumbs up, will go ahead and merge. Any further changes can be addressed in follow-up PRs...

@kgryte kgryte merged commit 0f64005 into data-apis:main Nov 6, 2023
@kgryte kgryte deleted the backport-indexing-type-fixes branch November 6, 2023 04:23
@Illviljan Illviljan mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honno honno honno approved these changes

Assignees
No one assigned
Labels
Backport Changes involve backporting to previous versions. topic: Indexing Array indexing.
Projects
None yet
Milestone
v2023
Development

Successfully merging this pull request may close these issues.
2 participants
@kgryte @honno