Skip to content

Add favicon #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2023
Merged

Add favicon #612

merged 3 commits into from
Mar 21, 2023
+24 −3

Conversation

steff456
Copy link
Member

Fixes #605

This PR,

  • Adds the logo asset to the static folder
  • Adds sphinx-favicon package as a dependency
  • Adds the missing favicon

@steff456 steff456 added the Maintenance Bug fix, typo fix, or general maintenance. label Mar 20, 2023
@steff456 steff456 requested review from asmeurer and rgommers March 20, 2023 19:32
@steff456 steff456 self-assigned this Mar 20, 2023
rgommers
rgommers approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works like a charm Thanks @steff456.

CI didn't trigger for some reason though, so let me close/reopen to see if that actually passes.

@rgommers rgommers closed this Mar 20, 2023
@rgommers rgommers reopened this Mar 20, 2023
@rgommers
Copy link
Member

Not sure what's up with CI - let me circle back to this once I open another PR.

@rgommers rgommers merged commit 371a4ed into data-apis:main Mar 21, 2023
@rgommers
Copy link
Member

Works now, merged. Thanks @steff456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

@asmeurer asmeurer Awaiting requested review from asmeurer

Assignees

@steff456 steff456

Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing favicon
2 participants
@steff456 @rgommers