-
Notifications
You must be signed in to change notification settings - Fork 52
Closed
Labels
topic: Complex Data TypesComplex number data types.Complex number data types.topic: Linear AlgebraLinear algebra.Linear algebra.
Milestone
Description
vecdot is defined for complex vectors as Unable to render expression.
$\langle x, y \rangle = \sum_i x_i \overline{y_i}$
Unable to render expression.
$\langle x, y \rangle = y^H x$
In PyTorch we define it as Unable to render expression.
$\langle x, y \rangle = x^H y$
I would argue that numerical libraries are more targeted to physics people than to pure math people, so perhaps it'd be better to stick with the physics notation?
Metadata
Metadata
Assignees
Labels
topic: Complex Data TypesComplex number data types.Complex number data types.topic: Linear AlgebraLinear algebra.Linear algebra.
Type
Projects
Relationships
Development
Select code repository
Activity
asmeurer commentedon Apr 3, 2023
I've transferred this issue to the array-api repo.
kgryte commentedon Apr 4, 2023
What is the ask here? Is this just a question about updating the docs or something else?
lezcano commentedon Apr 4, 2023
It's a question about the definition of
vecdot
for complex inputs in the array API (should it conjugate the first or the second input?)vecdot
#723kgryte commentedon Dec 18, 2023
This issue has been closed by #723. During the workgroup meeting on 30 Nov, we discussed this issue and consensus was to align the definition of the complex inner product with PyTorch and NumPy, as described in the OP. The definition previously in the spec was an oversight, and the changes have been backported to the 2022 revision of the API standard.