Some fixes for v2022.12 #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should have been using xp.real(x) instead of x.real. I'm not sure if float(x) or complex(x) would be better instead.
honno
reviewed
Jun 13, 2023
array_api_tests/dtype_helpers.py
Outdated
| @@ -157,19 +157,18 @@ def is_int_dtype(dtype): | |||
| return dtype in all_int_dtypes | |||
|
|
|||
|
|
|||
| def is_float_dtype(dtype): | |||
| def is_float_dtype(dtype, real=False): | |||
There was a problem hiding this comment.
- Lets make this new argument kw-only
- This is bikeshedding so feel free to ignore, just to say I think I'd prefer a more descriptive kwarg like
real_only=Falseorinclude_complex=True.
|
Merging as that was your only comment and I need this for the compat library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These came up in updating numpy.array_api.