Skip to content

P3491R3 define_static_{string,object,array} #8043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

P3491R3 define_static_{string,object,array} #8043

merged 2 commits into from
Jul 14, 2025

Conversation

Eisenwave
Copy link
Member

Closes #7933.
Also closes cplusplus/papers#2158.

@Eisenwave
Copy link
Member Author

@jensmaurer @jwakely there are some FIXMEs in here that I need your expertise on.

@Eisenwave Eisenwave mentioned this pull request Jul 14, 2025
Merged
@Eisenwave Eisenwave force-pushed the motions-2025-06-cwg-7 branch from 1c11ffe to 78113df Compare July 14, 2025 20:33
@Eisenwave
Copy link
Member Author

Eisenwave commented Jul 14, 2025 •
edited
Loading

Ok, you know what, it's not even worth rebasing this one right now because it indents the entirety of the [meta.syn] synopsis. There's no way this thing doesn't merge conflict until motions 6 is on main.

I figured out a solution; I've left the indentation change as a FIXME. This also makes it much easier to review. Once done, just remove the comment and indent everything by two spaces, it'll work out.

@Eisenwave Eisenwave force-pushed the motions-2025-06-cwg-7 branch 2 times, most recently from 56dd211 to abb32b2 Compare July 14, 2025 20:45
@tkoeppe tkoeppe force-pushed the motions-2025-06-cwg-7 branch from abb32b2 to 46c5455 Compare July 14, 2025 20:53
jwakely
jwakely reviewed Jul 14, 2025
View reviewed changes
Eisenwave and others added 2 commits July 14, 2025 22:11
@Eisenwave @tkoeppe
P3491R3 define_static_{string,object,array}
812eae5 
Editorial notes:
* The: header synopsis uses two separate sets of complete namespace
  declarations, which is clearer that opening a subnamespace half-way
  through.
* The two headings "Promoting to Static Storage" have been given
  unique names and regular capitalization.
* "clause" changed to "subclause" where appropriate.
@tkoeppe
[meta.reflection.array] Use usual "<boolean> is true" phrasing
ec9737c
@tkoeppe tkoeppe force-pushed the motions-2025-06-cwg-7 branch from 46c5455 to ec9737c Compare July 14, 2025 21:12
@tkoeppe tkoeppe merged commit 6714f27 into cplusplus:main Jul 14, 2025
2 checks passed
@Eisenwave Eisenwave mentioned this pull request Jul 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely left review comments

@tkoeppe tkoeppe tkoeppe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2025-06 CWG Motion 7] P3491R3 define_static_{string,object,array} P3491 R2 define_static_{string,object,array}
3 participants
@Eisenwave @jwakely @tkoeppe