Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response is compressed when not requested #485

Closed
pferrot opened this issue Jun 28, 2016 · 7 comments · Fixed by #490
Closed

Response is compressed when not requested #485

pferrot opened this issue Jun 28, 2016 · 7 comments · Fixed by #490
Labels
Milestone

Comments

@pferrot
Copy link

pferrot commented Jun 28, 2016

I have a backend application that supports optional response compression (see here for details).

Since 1.0 RC3, the response is compressed even if not requested. E.g. I hit http://myserver/path/to/service/version with my browser: it is supposed to return some JSON, but the browser actually prompts me to download a version.gzfile, which itself contains a version file with the actual JSON. This was not the case with previous versions (inculding RC2), i.e. I would see the actual JSON in the browser window.

It looks like (just guesses, I did not do much investigation) that Traefik now requests the response to be compressed from the backend but does not uncompress it before sending it to the original client...!?

@emilevauge emilevauge added the bug label Jun 28, 2016
@emilevauge emilevauge added this to the 1.0 milestone Jun 28, 2016
@emilevauge
Copy link
Member

@pferrot sadly, I can't reproduce this one :'(
I tried using a backend that accepts gzip compression (emilevauge/whoami) but it never ends in this issue. Could you provide a docker-compose file that reproduces this issue?

@emilevauge
Copy link
Member

@pferrot Did you activate retry request ?

@pferrot
Copy link
Author

pferrot commented Jul 6, 2016

Yes, I have retryenabled, with a fixed value (attempts = 10 if I remember correctly). I will test the latest build when I am back from vacation :-)

@pferrot
Copy link
Author

pferrot commented Jul 12, 2016

I confirm that I cannot reproduce the issue with the v1.0.0 release. Thanks and congrats for that big milestone!

@gardnervickers
Copy link

I am seeing this behavior on v1.1.0, but not on v1.0.0.

@emilevauge
Copy link
Member

@gardnervickers Can you give more details ? Are you using retry ?

@gardnervickers
Copy link

@emilevauge I was not using retry but I am seeing the same behavior with:

[retry]
attempts = 3

I am using these charts to deploy traefik with helm to Kubernetes in order provide ingress to our Jenkins dash.
https://github.com/kubernetes/charts/tree/master/stable/traefik

I know that's not a lot to go on, I'll try to make a better repro.

@ldez ldez added the kind/bug/confirmed a confirmed bug (reproducible). label Apr 29, 2017
@traefik traefik locked and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants