Return Unimplemented when services or methods are not implemented #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 69.77% 70.58% +0.81%
==========================================
Files 11 11
Lines 612 612
==========================================
+ Hits 427 432 +5
+ Misses 149 144 -5
Partials 36 36
Continue to review full report at Codecov.
|
gRPC has UNIMPLEMENTED status code that indicates a requested method is not implemented. However ttrpc was returning codes.NotFound which could be returned when a request entity was not there. This fix changes the status code from codes.NotFound to codes.Unimplemented to disambiguate and be more compatible with gRPC. Fixes containerd#80. Signed-off-by: Kazuyoshi Kato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC has UNIMPLEMENTED status code that indicates a requested method
is not implemented. However ttrpc was returning codes.NotFound which
could be returned when a request entity was not there.
This fix changes the status code from codes.NotFound to
codes.Unimplemented to disambiguate and be more compatible with gRPC.
Signed-off-by: Kazuyoshi Kato [email protected]